src: explain implementation of vm module #16962
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
cjihrig
approved these changes
Nov 12, 2017
src/node_contextify.cc
Outdated
| @@ -64,8 +64,29 @@ using v8::UnboundScript; | |||
| using v8::Value; | |||
| using v8::WeakCallbackInfo; | |||
|
|
|||
| // The vm module exectues code in a sandboxed environment with a different | |||
targos
approved these changes
Nov 12, 2017
src/node_contextify.cc
Outdated
| @@ -64,8 +64,29 @@ using v8::UnboundScript; | |||
| using v8::Value; | |||
| using v8::WeakCallbackInfo; | |||
|
|
|||
| // The vm module exectues code in a sandboxed environment with a different | |||
| // global object than the rest of the code. This is archieved by applying | |||
gireeshpunathil
approved these changes
Nov 12, 2017
fhinkel
force-pushed
the
nov/explain-interceptors
branch
from
09a86fc to
43a1bb2
Compare
The vm module uses interceptors on the object template. This is not straight forward and a comment in the source will help the next person working on this.
fhinkel
force-pushed
the
nov/explain-interceptors
branch
from
43a1bb2 to
4982514
Compare
jasnell
approved these changes
Nov 12, 2017
addaleax
approved these changes
Nov 12, 2017
|
Since this is only adding a comment, just going to lint: https://ci.nodejs.org/job/node-test-linter/13499/ |
jasnell
pushed a commit
that referenced
this pull request
Nov 12, 2017
The vm module uses interceptors on the object template. This is not straight forward and a comment in the source will help the next person working on this. PR-URL: #16962 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
|
Landed in f0c674d |
evanlucas
pushed a commit
that referenced
this pull request
Nov 13, 2017
The vm module uses interceptors on the object template. This is not straight forward and a comment in the source will help the next person working on this. PR-URL: #16962 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
|
Should this be backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vm module uses interceptors on the object template. This is not
straight forward and a comment in the source will help the next
person (and future me) working on this.
Checklist
make lintpassesAffected core subsystem(s)
src - but only adding a comment