Skip to content

doc: fix typo in esm.md #18142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

doc: fix typo in esm.md #18142

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 14, 2018

Change run time to runtime for both correctness and consistency with
every other instance of the expression in the docs.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@Trott
doc: fix typo in esm.md
fa0b214 
Change `run time` to `runtime` for both correctness and consistency with
every other instance of the expression in the docs.
@Trott Trott added the doc Issues and PRs related to the documentations. label Jan 14, 2018
@Trott
Copy link
Member Author

Trott commented Jan 14, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request-lite/85/

@devsnek
Copy link
Member

devsnek commented Jan 14, 2018

sorry about this 😄

@maclover7 maclover7 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 18, 2018
@Trott
Copy link
Member Author

Trott commented Jan 18, 2018

Landed in 359a232

@Trott Trott closed this Jan 18, 2018
Trott added a commit that referenced this pull request Jan 18, 2018
@Trott
doc: fix typo in esm.md
359a232 
Change `run time` to `runtime` for both correctness and consistency with
every other instance of the expression in the docs.

PR-URL: #18142
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 18, 2018
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@Trott @MayaLekova
doc: fix typo in esm.md
e55fc57 
Change `run time` to `runtime` for both correctness and consistency with
every other instance of the expression in the docs.

PR-URL: nodejs#18142
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
@Trott Trott deleted the runtime branch January 13, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

@danbev danbev danbev approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@cjihrig cjihrig cjihrig approved these changes

@XadillaX XadillaX XadillaX approved these changes

@maclover7 maclover7 maclover7 approved these changes

@tniessen tniessen tniessen approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.