src: fix deprecation id for non-string env value #19209
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up of nodejs#18990. A new deprecation id was assigned in it, but it was not reflected in code and test.
nodejs-github-bot
added
the
c++
TimothyGu
approved these changes
Mar 7, 2018
|
Sorry, my bad. |
joyeecheung
approved these changes
Mar 7, 2018
|
linuxONE + linter are passing. For the interest of time I've landed this in 50b1cb3. |
TimothyGu
pushed a commit
that referenced
this pull request
Mar 7, 2018
This is a follow-up of #18990. A new deprecation id was assigned in it, but it was not reflected in code and test. PR-URL: #19209 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
This is a follow-up of nodejs#18990. A new deprecation id was assigned in it, but it was not reflected in code and test. PR-URL: nodejs#19209 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of #18990. A new
deprecation id was assigned in it, but it was not reflected in code and
test.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes