src: improve fatal exception #20294
Closed
src: improve fatal exception #20294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just some code cleanup.
nodejs-github-bot
added
the
c++
addaleax
approved these changes
Apr 25, 2018
src/node.cc
Outdated
|
|
||
| if (exit_code == 0 && false == caught->BooleanValue()) { | ||
| exit(7); | ||
| } else if (false == caught->BooleanValue()) { |
There was a problem hiding this comment.
Can we either un-yoda-ize this and make it use the non-deprecated overload of BooleanValue, or switch to if (caught->IsFalse())?
|
CI-Lite: https://ci.nodejs.org/job/node-test-pull-request-lite/597/ (should be enough to reconfirm). |
lpinca
approved these changes
Apr 26, 2018
lpinca
added
the
author ready
jasnell
approved these changes
Apr 27, 2018
addaleax
added
the
lib / src
|
Landed in b87ef18 |
addaleax
removed
the
author ready
addaleax
pushed a commit
that referenced
this pull request
Apr 27, 2018
This is just some code cleanup. PR-URL: #20294 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 4, 2018
This is just some code cleanup. PR-URL: #20294 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just some code cleanup.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes