crypto: use new OpenSSL constants in CipherBase #20339
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change replaces some constants with better alternatives which were unavailable in OpenSSL 1.0.2. Refs: nodejs#19794 Refs: nodejs#18138
nodejs-github-bot
added
c++
|
cc @nodejs/crypto |
bnoordhuis
approved these changes
Apr 26, 2018
|
Setting |
|
Thank you, @richardlau. CI: https://ci.nodejs.org/job/node-test-pull-request/14536/ |
danbev
approved these changes
Apr 27, 2018
cjihrig
approved these changes
Apr 27, 2018
BridgeAR
added
the
author ready
jasnell
approved these changes
Apr 27, 2018
|
Linter fixed, CI: https://ci.nodejs.org/job/node-test-pull-request/14597/ |
|
Landed in 0e63724. |
tniessen
added a commit
that referenced
this pull request
Apr 30, 2018
This change replaces some constants with better alternatives which were unavailable in OpenSSL 1.0.2. PR-URL: #20339 Refs: #19794 Refs: #18138 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 4, 2018
This change replaces some constants with better alternatives which were unavailable in OpenSSL 1.0.2. PR-URL: #20339 Refs: #19794 Refs: #18138 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
tniessen
removed
the
author ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces some constants with better alternatives which were unavailable in OpenSSL 1.0.2.
Refs: #19794
Refs: #18138
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes