Skip to content

assert: support symbols as assertion messages #20693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2018
Merged

assert: support symbols as assertion messages #20693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/internal/assert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ class AssertionError extends Error {
} = options;

if (message != null) {
super(message);
super(String(message));
} else {
if (process.stdout.isTTY) {
// Reset on each call to make sure we handle dynamically set environment
Expand Down
10 changes: 10 additions & 0 deletions test/parallel/test-assert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -640,6 +640,16 @@ common.expectsError(
}
);

common.expectsError(
() => assert(false, Symbol('foo')),
{
code: 'ERR_ASSERTION',
type: assert.AssertionError,
generatedMessage: false,
message: 'Symbol(foo)'
}
);

{
// Test caching.
const fs = process.binding('fs');
Expand Down