Skip to content

Conversation

addaleax
Copy link
Member

This backport differs from the original only in the
omission of a change to stream_base-inl.h which
would have generated conflicts.

PR-URL: #19204

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

This backport differs from the original only in the
omission of a change to `stream_base-inl.h` which
would have generated conflicts.

PR-URL: nodejs#19204
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. v8.x labels Jun 30, 2018
MylesBorins pushed a commit that referenced this pull request Jul 13, 2018
This backport differs from the original only in the
omission of a change to `stream_base-inl.h` which
would have generated conflicts.

Backport-PR-URL: #21600
PR-URL: #19204
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
@MylesBorins
Copy link
Contributor

landed in 0d41b02

rvagg pushed a commit that referenced this pull request Aug 16, 2018
This backport differs from the original only in the
omission of a change to `stream_base-inl.h` which
would have generated conflicts.

Backport-PR-URL: #21600
PR-URL: #19204
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants