Skip to content

doc: improve guide text for CI runs #21645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

doc: improve guide text for CI runs #21645

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4691862
doc: improve guide text for CI runs
Trott Jul 3, 2018
e7aaf17
squash! formatting
Trott Jul 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions COLLABORATOR_GUIDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,14 +199,10 @@ status indicator.

Do not land any Pull Requests without passing (green or yellow) CI runs. If you
believe any failed (red or grey) CI sub-tasks are unrelated to the change in the
Pull Request, you may re-run the sub-task to try to see if it passes (just open
the failed sub-task page and press the "Rebuild" button; be sure you are still
logged in for this action). If re-runs of all failed sub-tasks pass (do not
forget to provide the links for successfully rerun sub-tasks), it is permissible
to land the Pull Request but only if the initial failures are believed in good
faith to be unrelated to the changes in the Pull Request. Otherwise, reasonable
steps must be taken to confirm that the changes are not resulting in an
unreliable test.
Pull Request, use "Resume Build" in the left navigation of the relevant
`node-test-pull-request` job. It will create a new `node-test-pull-request` run
that preserves all the green results from the current job but re-runs everything
else.

#### Useful CI Jobs

Expand Down