test: remove third argument from call to assert.strictEqual() #22047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
approved these changes
Jul 31, 2018
lpinca
approved these changes
Jul 31, 2018
richardlau
approved these changes
Aug 1, 2018
Trott
approved these changes
Aug 1, 2018
jasnell
approved these changes
Aug 1, 2018
trivikr
approved these changes
Aug 1, 2018
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/16133/ |
BridgeAR
approved these changes
Aug 1, 2018
BridgeAR
added
fast-track
|
+1 to fast-tracking. |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Aug 2, 2018
PR-URL: nodejs#22047 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
|
Landed in 1f56c56 |
targos
pushed a commit
that referenced
this pull request
Aug 2, 2018
PR-URL: #22047 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
This was referenced Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the third argument from call to assert.strictEqual because it prevents the value of
sha1Hash.digest('hex')from being displayed if an AssertionError occurs. The third argument is retained as a comment.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes