-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
child_process: handling fork( path, undefined / null, obj ) #22416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4ffbf08
child_process: handling fork( path, undefined / null, obj )
shobhitchittora deda17f
child_process: adds test + indentation fix
shobhitchittora 331ecbe
child_process: fixes typo + lint fix
shobhitchittora 262c9c1
child_process: refactored test as per the comments + alignment fix
shobhitchittora 3889080
child_process: removes exit(0) from the test
shobhitchittora 9d771cf
child_process: adding on exit handle
shobhitchittora ee71420
child_process: extending process.env
shobhitchittora 2cf060d
child_process: adds test for null check
shobhitchittora File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
process.send({ env: process.env }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
'use strict'; | ||
const common = require('../common'); | ||
const fixtures = require('../common/fixtures'); | ||
|
||
// This test ensures that fork should parse options | ||
// correctly if args is undefined or null | ||
|
||
const assert = require('assert'); | ||
const { fork } = require('child_process'); | ||
|
||
const expectedEnv = { foo: 'bar' }; | ||
|
||
{ | ||
const cp = fork(fixtures.path('child-process-echo-options.js'), undefined, | ||
{ env: Object.assign({}, process.env, expectedEnv) }); | ||
|
||
cp.on('message', common.mustCall(({ env }) => { | ||
assert.strictEqual(env.foo, expectedEnv.foo); | ||
})); | ||
|
||
cp.on('exit', common.mustCall((code) => { | ||
assert.strictEqual(code, 0); | ||
})); | ||
} | ||
|
||
{ | ||
const cp = fork(fixtures.path('child-process-echo-options.js'), null, | ||
{ env: Object.assign({}, process.env, expectedEnv) }); | ||
|
||
cp.on('message', common.mustCall(({ env }) => { | ||
assert.strictEqual(env.foo, expectedEnv.foo); | ||
})); | ||
|
||
cp.on('exit', common.mustCall((code) => { | ||
assert.strictEqual(code, 0); | ||
})); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.