Improving error messages description #22983
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improve error message description for http server binding errors. change only in 'setupListenHandle' but needs to be change all over. 1. added new `uvExceptionWithHostPort` function (+export) in 'lib/internal/error.js' that extracts the error message defined by libuv using the error code, and returns an error object with the error full description. Instead of 'EADDRINUSE' -> 'address already in use' 2. removed exportable function `_exceptionWithHostPort` from lib/util.js - it was exported by accident 3. replaced 'exceptionWithHostPort' to the new function `uvExceptionWithHostPort` for a more detailed error.
nodejs-github-bot
added
errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib: improved error message description for the http server binding errors.
changed in
setupListenHandle, but needs to be change all over.Added new
uvExceptionWithHostPortfunction (+export) inlib/internal/error.jsthat extracts the error message defined by libuv, using the error code, and returns an error object with the full error description: 'address already in use' for example.Removed exportable function
_exceptionWithHostPortfromlib/util.js- exported by accidentReplaced
exceptionWithHostPortto the new functionuvExceptionWithHostPortfor a more detailed error.Fixes: #22936
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes