Skip to content

test: improve test-gc-http-client-onerror #23196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

test: improve test-gc-http-client-onerror #23196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 19 additions & 22 deletions test/sequential/test-gc-http-client-onerror.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// just like test-gc-http-client.js,
// but with an on('error') handler that does nothing.

require('../common');
const common = require('../common');
const onGC = require('../common/ongc');

function serverHandler(req, res) {
Expand All @@ -21,37 +21,34 @@ let countGC = 0;
console.log(`We should do ${todo} requests`);

const server = http.createServer(serverHandler);
server.listen(0, runTest);
server.listen(0, common.mustCall(() => {
for (let i = 0; i < 10; i++)
getall();
}));

function getall() {
if (count >= todo)
return;

(function() {
function cb(res) {
res.resume();
done += 1;
}
function onerror(er) {
throw er;
}
const req = http.get({
hostname: 'localhost',
pathname: '/',
port: server.address().port
}, cb).on('error', onerror);

const req = http.get({
hostname: 'localhost',
pathname: '/',
port: server.address().port
}, cb).on('error', onerror);

count++;
onGC(req, { ongc });
})();
count++;
onGC(req, { ongc });

setImmediate(getall);
}

function runTest() {
for (let i = 0; i < 10; i++)
getall();
function cb(res) {
res.resume();
done += 1;
}

function onerror(err) {
throw err;
}

function ongc() {
Expand Down