lib: remove some useless assignments #23199
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
events
addaleax
approved these changes
Oct 1, 2018
cjihrig
approved these changes
Oct 1, 2018
BridgeAR
approved these changes
Oct 1, 2018
mscdex
reviewed
Oct 1, 2018
| @@ -1081,10 +1081,6 @@ function afterConnect(status, handle, req, readable, writable) { | |||
| return; | |||
| } | |||
|
|
|||
| // Update handle if it was wrapped | |||
| // TODO(indutny): assert that the handle is actually an ancestor of old one | |||
There was a problem hiding this comment.
Should this TODO be removed?
There was a problem hiding this comment.
that's why I pinged @indutny
There was a problem hiding this comment.
I'm afraid I no longer remember what this was about. This comments is years old.
There was a problem hiding this comment.
Perhaps this particular change alone can be done in a separate PR then?
addaleax
added
the
author ready
|
Re-run of failing node-test-commit-arm ✔️ |
devsnek
removed
the
author ready
|
this can't land until @indutny confirms the removal of that line |
|
Given that @indutny isn't sure what the line refers to, I think it's acceptable to remove it as no one else is likely to know either. |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 5, 2018
PR-URL: nodejs#23199 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
|
Landed in 366aaf5 |
BridgeAR
pushed a commit
that referenced
this pull request
Dec 6, 2018
PR-URL: #23199 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
Dec 7, 2018
PR-URL: #23199 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
Dec 7, 2018
PR-URL: #23199 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
This was referenced Dec 7, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#23199 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 12, 2019
PR-URL: #23199 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Feb 20, 2019
PR-URL: #23199 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
PR-URL: #23199 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @indutny
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes