Skip to content

src: refactor deprecated v8::Function::Call call #23804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2018
Merged

src: refactor deprecated v8::Function::Call call #23804

merged 1 commit into from
Oct 23, 2018

Conversation

RomainLanz
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Refs: #23414 (comment)

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Oct 21, 2018
targos
targos reviewed Oct 21, 2018
View reviewed changes
addaleax
addaleax approved these changes Oct 21, 2018
View reviewed changes
@targos
Copy link
Member

targos commented Oct 21, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18030/

@targos
Copy link
Member

targos commented Oct 21, 2018

I think we have a new flaky test! Opened #23807 to track.

oyyd added a commit to oyyd/node that referenced this pull request Oct 23, 2018
@oyyd
src: use maybe version v8::Function::Call
c6d40a2 
Refs: nodejs#23804
@oyyd oyyd mentioned this pull request Oct 23, 2018
Closed
2 tasks
@refack
Copy link
Contributor

refack commented Oct 23, 2018

CI: https://ci.nodejs.org/job/node-test-commit/22579/ ✔️

@RomainLanz @refack
src: refactor deprecated v8::Function::Call call
341006b 
Refs: nodejs#23414 (comment)

PR-URL: nodejs#23804
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@refack refack merged commit 341006b into nodejs:master Oct 23, 2018
@refack
Copy link
Contributor

refack commented Oct 23, 2018

@RomainLanz thank you for the contribution 🎉

Landed in 341006b

targos pushed a commit that referenced this pull request Oct 24, 2018
@RomainLanz @targos
src: refactor deprecated v8::Function::Call call
df05ddf 
Refs: #23414 (comment)

PR-URL: #23804
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Oct 25, 2018
@oyyd @addaleax
src: use maybe version v8::Function::Call
d8924a0 
Refs: #23804

PR-URL: #23826
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Oct 26, 2018
@oyyd @targos
src: use maybe version v8::Function::Call
02d83d4 
Refs: #23804

PR-URL: #23826
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Oct 27, 2018
Merged
targos pushed a commit that referenced this pull request Nov 1, 2018
@oyyd @targos
src: use maybe version v8::Function::Call
ce106df 
Refs: #23804

PR-URL: #23826
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This was referenced Nov 2, 2018
Closed
Closed
Closed
Closed
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
@RomainLanz @MylesBorins
src: refactor deprecated v8::Function::Call call
2e3e68a 
Refs: #23414 (comment)

PR-URL: #23804
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@RomainLanz @rvagg
src: refactor deprecated v8::Function::Call call
bf4c798 
Refs: #23414 (comment)

PR-URL: #23804
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@RomainLanz @MylesBorins
src: refactor deprecated v8::Function::Call call
17db407 
Refs: #23414 (comment)

PR-URL: #23804
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
BethGriggs pushed a commit that referenced this pull request Oct 18, 2019
@oyyd @BethGriggs
src: use maybe version v8::Function::Call
18b140a 
Refs: #23804

PR-URL: #23826
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@targos targos targos approved these changes

+2 more reviewers

@refack refack refack approved these changes

@lundibundi lundibundi lundibundi approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@RomainLanz @targos @refack @jasnell @addaleax @lundibundi @MylesBorins @nodejs-github-bot