Skip to content

lib: convert to arrow function in fs.js #24604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

lib: convert to arrow function in fs.js #24604

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions lib/fs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ function makeCallback(cb) {
throw new ERR_INVALID_CALLBACK();
}

return function(...args) {
return (...args) => {
return Reflect.apply(cb, undefined, args);
};
}
Expand All @@ -157,7 +157,7 @@ function makeStatsCallback(cb) {
throw new ERR_INVALID_CALLBACK();
}

return function(err, stats) {
return (err, stats) => {
if (err) return cb(err);
cb(err, getStatsFromBinding(stats));
};
Expand Down Expand Up @@ -631,11 +631,11 @@ function truncate(path, len, callback) {

validateInteger(len, 'len');
callback = maybeCallback(callback);
fs.open(path, 'r+', function(er, fd) {
fs.open(path, 'r+', (er, fd) => {
if (er) return callback(er);
const req = new FSReqCallback();
req.oncomplete = function oncomplete(er) {
fs.close(fd, function(er2) {
fs.close(fd, (er2) => {
callback(er || er2);
});
};
Expand Down Expand Up @@ -995,15 +995,15 @@ function fchmodSync(fd, mode) {

function lchmod(path, mode, callback) {
callback = maybeCallback(callback);
fs.open(path, O_WRONLY | O_SYMLINK, function(err, fd) {
fs.open(path, O_WRONLY | O_SYMLINK, (err, fd) => {
if (err) {
callback(err);
return;
}
// Prefer to return the chmod error, if one occurs,
// but still try to close, and report closing errors if they occur.
fs.fchmod(fd, mode, function(err) {
fs.close(fd, function(err2) {
fs.fchmod(fd, mode, (err) => {
fs.close(fd, (err2) => {
callback(err || err2);
});
});
Expand Down Expand Up @@ -1152,7 +1152,7 @@ function futimesSync(fd, atime, mtime) {

function writeAll(fd, isUserFd, buffer, offset, length, position, callback) {
// write(fd, buffer, offset, length, position, callback)
fs.write(fd, buffer, offset, length, position, function(writeErr, written) {
fs.write(fd, buffer, offset, length, position, (writeErr, written) => {
if (writeErr) {
if (isUserFd) {
callback(writeErr);
Expand Down Expand Up @@ -1188,7 +1188,7 @@ function writeFile(path, data, options, callback) {
return;
}

fs.open(path, flag, options.mode, function(openErr, fd) {
fs.open(path, flag, options.mode, (openErr, fd) => {
if (openErr) {
callback(openErr);
} else {
Expand Down Expand Up @@ -1531,7 +1531,7 @@ function realpathSync(p, options) {
}


realpathSync.native = function(path, options) {
realpathSync.native = (path, options) => {
options = getOptions(options, {});
path = toPathIfFileURL(path);
validatePath(path);
Expand Down Expand Up @@ -1572,7 +1572,7 @@ function realpath(p, options, callback) {

// On windows, check that the root exists. On unix there is no need.
if (isWindows && !knownHard[base]) {
fs.lstat(base, function(err, stats) {
fs.lstat(base, (err, stats) => {
if (err) return callback(err);
knownHard[base] = true;
LOOP();
Expand Down Expand Up @@ -1636,10 +1636,10 @@ function realpath(p, options, callback) {
return gotTarget(null, seenLinks[id], base);
}
}
fs.stat(base, function(err) {
fs.stat(base, (err) => {
if (err) return callback(err);

fs.readlink(base, function(err, target) {
fs.readlink(base, (err, target) => {
if (!isWindows) seenLinks[id] = target;
gotTarget(err, target);
});
Expand All @@ -1660,7 +1660,7 @@ function realpath(p, options, callback) {

// On windows, check that the root exists. On unix there is no need.
if (isWindows && !knownHard[base]) {
fs.lstat(base, function(err) {
fs.lstat(base, (err) => {
if (err) return callback(err);
knownHard[base] = true;
LOOP();
Expand All @@ -1672,7 +1672,7 @@ function realpath(p, options, callback) {
}


realpath.native = function(path, options, callback) {
realpath.native = (path, options, callback) => {
callback = makeCallback(callback || options);
options = getOptions(options, {});
path = toPathIfFileURL(path);
Expand Down