Skip to content

Conversation

targos
Copy link
Member

@targos targos commented Nov 28, 2018

This is #24642 applied cleanly + two whitespace fixes that were included in 2c2e6ec38d1 (release commits are not backported)

PR-URL: nodejs#24642
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
PR-URL: nodejs#24642
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. v11.x labels Nov 28, 2018
targos pushed a commit that referenced this pull request Nov 30, 2018
Backport-PR-URL: #24699
PR-URL: #24642
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Nov 30, 2018
Backport-PR-URL: #24699
PR-URL: #24642
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos
Copy link
Member Author

targos commented Nov 30, 2018

Landed in 654bd65 and e7fbdf5

@targos targos closed this Nov 30, 2018
@targos targos deleted the backport-24642 branch November 30, 2018 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants