Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/_http_server.js
Original file line number Diff line number Diff line change
Expand Up @@ -512,8 +512,7 @@ function socketOnError(e) {

if (!this.server.emit('clientError', e, this)) {
if (this.writable) {
this.end(badRequestResponse);
return;
this.write(badRequestResponse);
}
this.destroy(e);
}
Expand Down
45 changes: 45 additions & 0 deletions test/parallel/test-http-server-destroy-socket-on-client-error.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
'use strict';

const { expectsError, mustCall } = require('../common');

// Test that the request socket is destroyed if the `'clientError'` event is
// emitted and there is no listener for it.

const assert = require('assert');
const { createServer } = require('http');
const { createConnection } = require('net');

const server = createServer();

server.on('connection', mustCall((socket) => {
socket.on('error', expectsError({
type: Error,
message: 'Parse Error',
code: 'HPE_INVALID_METHOD',
bytesParsed: 0,
rawPacket: Buffer.from('FOO /\r\n')
}));
}));

server.listen(0, () => {
const chunks = [];
const socket = createConnection({
allowHalfOpen: true,
port: server.address().port
});

socket.on('connect', mustCall(() => {
socket.write('FOO /\r\n');
}));

socket.on('data', (chunk) => {
chunks.push(chunk);
});

socket.on('end', mustCall(() => {
const expected = Buffer.from('HTTP/1.1 400 Bad Request\r\n\r\n');
assert(Buffer.concat(chunks).equals(expected));

server.close();
}));
});