src: remove finalized_ member from Hash class #24822
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the finalized_ member from the Hash class as it does not seem to be used in any valuable way. Commit c75f87c ("crypto: refactor the crypto module") removed the check where it was previously used.
nodejs-github-bot
added
c++
addaleax
approved these changes
Dec 4, 2018
joyeecheung
approved these changes
Dec 4, 2018
cjihrig
approved these changes
Dec 4, 2018
lpinca
approved these changes
Dec 4, 2018
|
Landed in cbf0e5a. |
danbev
added a commit
that referenced
this pull request
Dec 7, 2018
This commit removes the finalized_ member from the Hash class as it does not seem to be used in any valuable way. Commit c75f87c ("crypto: refactor the crypto module") removed the check where it was previously used. PR-URL: #24822 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 7, 2018
This commit removes the finalized_ member from the Hash class as it does not seem to be used in any valuable way. Commit c75f87c ("crypto: refactor the crypto module") removed the check where it was previously used. PR-URL: #24822 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
This commit removes the finalized_ member from the Hash class as it does not seem to be used in any valuable way. Commit c75f87c ("crypto: refactor the crypto module") removed the check where it was previously used. PR-URL: nodejs#24822 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 12, 2019
This commit removes the finalized_ member from the Hash class as it does not seem to be used in any valuable way. Commit c75f87c ("crypto: refactor the crypto module") removed the check where it was previously used. PR-URL: #24822 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Feb 20, 2019
This commit removes the finalized_ member from the Hash class as it does not seem to be used in any valuable way. Commit c75f87c ("crypto: refactor the crypto module") removed the check where it was previously used. PR-URL: #24822 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
This commit removes the finalized_ member from the Hash class as it does not seem to be used in any valuable way. Commit c75f87c ("crypto: refactor the crypto module") removed the check where it was previously used. PR-URL: #24822 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the finalized_ member from the Hash class as it does
not seem to be used in any valuable way. Commit c75f87c ("crypto:
refactor the crypto module") removed the check where it was previously
used.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes