test: removing unused arguments, and conversion ES6 arrow function common.mustCall #24976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntax in test/async-hooks/test-enable-in-init.js
nodejs-github-bot
added
async_hooks
mitchhankins01
changed the title
Trott
approved these changes
Dec 12, 2018
danbev
approved these changes
Dec 12, 2018
cjihrig
approved these changes
Dec 12, 2018
Trott
added
the
author ready
|
Landed in 848ae89 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 14, 2018
Remove unused function arguments. Convert to ES6 arrow syntax. PR-URL: nodejs#24976 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
BethGriggs
pushed a commit
that referenced
this pull request
Dec 18, 2018
Remove unused function arguments. Convert to ES6 arrow syntax. PR-URL: #24976 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Remove unused function arguments. Convert to ES6 arrow syntax. PR-URL: nodejs#24976 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 12, 2019
Remove unused function arguments. Convert to ES6 arrow syntax. PR-URL: #24976 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Feb 20, 2019
Remove unused function arguments. Convert to ES6 arrow syntax. PR-URL: #24976 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
Remove unused function arguments. Convert to ES6 arrow syntax. PR-URL: #24976 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: removing unused arguments, and conversion ES6 arrow function common.mustCall
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes