Skip to content

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Dec 17, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem. labels Dec 17, 2018
@sam-github
Copy link
Contributor

Thanks for fixing this for me.

Could be fast-tracked.

@vsemozhetbyt vsemozhetbyt added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Dec 17, 2018
@Trott
Copy link
Member

Trott commented Dec 17, 2018

Landed in 928f776

@Trott Trott closed this Dec 17, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 17, 2018
PR-URL: nodejs#25091
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
@cjihrig cjihrig deleted the link branch December 19, 2018 14:17
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
PR-URL: nodejs#25091
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants