src: handle errors while printing error objects #25834
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle situations where accessing `.name` or `.stack` on an object fails. Fixes: nodejs#25718
nodejs-github-bot
added
the
c++
targos
approved these changes
Jan 30, 2019
JungMinu
approved these changes
Jan 31, 2019
Fishrock123
approved these changes
Jan 31, 2019
devsnek
approved these changes
Jan 31, 2019
cjihrig
approved these changes
Jan 31, 2019
|
Landed in f722540 |
addaleax
added a commit
that referenced
this pull request
Feb 3, 2019
Handle situations where accessing `.name` or `.stack` on an object fails. Fixes: #25718 PR-URL: #25834 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
addaleax
added a commit
that referenced
this pull request
Feb 3, 2019
Handle situations where accessing `.name` or `.stack` on an object fails. Fixes: #25718 PR-URL: #25834 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Nice @addaleax! I was just going to report this as: echo "var e = new Error;Reflect.defineProperty(e,'stack', { get() { throw new Error } });throw e" | nodecould cause a hard crash. I believe this PR fixed it since I do not hit the issue when I build from master. |
Merged
This was referenced Feb 15, 2019
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle situations where accessing
.nameor.stackon an objectfails.
Fixes: #25718
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes