Skip to content

test: add arg to narrow http benchmark test #26101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2019
Merged

test: add arg to narrow http benchmark test #26101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/benchmark/test-benchmark-http.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ runBenchmark('http',
'n=1',
'res=normal',
'type=asc',
'value=X-Powered-By'
'value=X-Powered-By',
'headerDuplicates=1',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you relocate it higher in the list to keep the list in alphabetical order?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you relocate it higher in the list to keep the list in alphabetical order?

Argh, never mind, it's already not alphabetical, just mostly alphabetical. Anyway, LGTM, but nit: Would prefer to alphabetize the list.

(Also, agree that n is probably better. The headers aren't duplicates. They're similarly-named.)

],
{
NODEJS_BENCHMARK_ZERO_ALLOWED: 1,
Expand Down