[v11.x backport] src: refactor node options parsers to mitigate MSVC bug #26649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
2 tasks
BridgeAR
force-pushed
the
v11.x-staging
branch
3 times, most recently
from
2beeaf8 to
f82e07b
Compare
|
@refack this needs a rebase. |
refack
force-pushed
the
backport-26280-to-v11.x
branch
from
022fd79 to
22c5bc6
Compare
|
@BridgeAR, done, PTAL. |
PR-URL: nodejs#26280 Fixes: nodejs#25593 Reviewed-By: Joyee Cheung <[email protected]>
* header explicit usage, order, and reduce use of `*-inl.h` * pointer -> const reference when possible * no variable recyclicng * `std::begin/end` prefered over `instance.begin/end` * `USE` for explicit unused resaults PR-URL: nodejs#26280 Fixes: nodejs#25593 Reviewed-By: Joyee Cheung <[email protected]>
refack
force-pushed
the
backport-26280-to-v11.x
branch
from
22c5bc6 to
1ad23f6
Compare
targos
pushed a commit
that referenced
this pull request
Mar 28, 2019
Backport-PR-URL: #26649 PR-URL: #26280 Fixes: #25593 Reviewed-By: Joyee Cheung <[email protected]>
targos
pushed a commit
that referenced
this pull request
Mar 28, 2019
* header explicit usage, order, and reduce use of `*-inl.h` * pointer -> const reference when possible * no variable recyclicng * `std::begin/end` prefered over `instance.begin/end` * `USE` for explicit unused resaults Backport-PR-URL: #26649 PR-URL: #26280 Fixes: #25593 Reviewed-By: Joyee Cheung <[email protected]>
targos
pushed a commit
that referenced
this pull request
Mar 30, 2019
* header explicit usage, order, and reduce use of `*-inl.h` * pointer -> const reference when possible * no variable recyclicng * `std::begin/end` prefered over `instance.begin/end` * `USE` for explicit unused resaults Backport-PR-URL: #26649 PR-URL: #26280 Fixes: #25593 Reviewed-By: Joyee Cheung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #26280
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes