src: add include guard for trace_event_common.h #26883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
|
This seems like it was intentional, according to the comment/error around line 200? |
|
This file looks like copy from v8 node/deps/v8/base/trace_event/common/trace_event_common.h Lines 197 to 199 in 7b48713 The original file has include guard node/deps/v8/base/trace_event/common/trace_event_common.h Lines 1 to 6 in 7b48713 |
addaleax
approved these changes
Mar 26, 2019
refack
reviewed
Mar 26, 2019
gengjiawen
force-pushed
the
ensure_include_once
branch
from
cf8edcf to
40bf4f7
Compare
refack
approved these changes
Mar 26, 2019
PR-URL: nodejs#26883 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
refack
force-pushed
the
ensure_include_once
branch
from
40bf4f7 to
975bc89
Compare
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 27, 2019
PR-URL: nodejs#26883 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
targos
pushed a commit
that referenced
this pull request
Mar 27, 2019
PR-URL: #26883 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes