Skip to content

Fix some clang-tidy issue and small refactor #27152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 11, 2019
Merged

Fix some clang-tidy issue and small refactor #27152

merged 2 commits into from
Apr 11, 2019

Conversation

gengjiawen
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. report Issues and PRs related to process.report. labels Apr 9, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22307/

@refack refack added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 9, 2019
@gengjiawen @refack
src: use macro instead of magic number for fd
845a621 
PR-URL: nodejs#27152
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@gengjiawen @refack
src: remove redundant string initialization
ee7daf7 
PR-URL: nodejs#27152
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@refack refack force-pushed the src_review_19_04_09 branch from 90a71f7 to ee7daf7 Compare April 11, 2019 15:15
@refack refack removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 11, 2019
@refack
Copy link
Contributor

refack commented Apr 11, 2019

Landed in:
845a621
ee7daf7

@refack refack merged commit ee7daf7 into nodejs:master Apr 11, 2019
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

+1 more reviewer

@refack refack refack approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. report Issues and PRs related to process.report.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gengjiawen @nodejs-github-bot @refack @jasnell @cjihrig @richardlau