Workaround for crash in #2721 on 4.0.0-rc #2726
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should be fixed deps/v8/src/api.cc Workaround solution will be the next commit
|
While this is convenient, beware that attribution for the original authors would get lost. I'll just use this PR for a CI run now: https://ci.nodejs.org/job/node-test-pull-request/261/ |
|
This was a bug in child_process |
|
Looks like #2727 fixes it, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the workaround solution for #2721 that was suggested by @evanlucas in #2722 (comment). Includes the test scenario that @pmq20 contributed in #2722.