deps: update nghttp2 to 1.38.0 #27295
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
dont-land-on-v6.x
http2
addaleax
approved these changes
Apr 18, 2019
|
Need to add |
cjihrig
approved these changes
Apr 19, 2019
jasnell
approved these changes
Apr 20, 2019
ZYSzys
approved these changes
Apr 21, 2019
ZYSzys
added
author ready
shisama
approved these changes
Apr 21, 2019
|
Landed in 2161690 🎉 |
ZYSzys
pushed a commit
that referenced
this pull request
Apr 22, 2019
PR-URL: #27295 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Masashi Hirano <[email protected]>
addaleax
removed
the
semver-minor
|
@gengjiawen This doesn’t appear to be a semver-minor change – our cherry-pick only contains a semver-patch part. |
This was referenced Apr 23, 2019
BethGriggs
pushed a commit
that referenced
this pull request
Aug 15, 2019
Backport-PR-URL: #29123 PR-URL: #27295 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Masashi Hirano <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Aug 15, 2019
PR-URL: #27295 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Masashi Hirano <[email protected]>
This was referenced Aug 15, 2019
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release: https://github.com/nghttp2/nghttp2/releases/tag/v1.38.0
Mainly Fix nghttp2/nghttp2#1331.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes