Skip to content

src: extract common macro to util.h #27512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

src: extract common macro to util.h #27512

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels May 1, 2019
bnoordhuis
bnoordhuis reviewed May 1, 2019
View reviewed changes
refack
refack reviewed May 1, 2019
View reviewed changes
cjihrig
cjihrig approved these changes May 1, 2019
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with comments addressed.

@gengjiawen gengjiawen force-pushed the group_path_sep branch 2 times, most recently from 5df1eeb to 4c9b6f4 Compare May 1, 2019 14:29
@BridgeAR
Copy link
Member

BridgeAR commented May 3, 2019

This needs a rebase.

@gengjiawen
Copy link
Member Author

This needs a rebase.

Done, thanks.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22930/

@gengjiawen
Copy link
Member Author

Rebase again due to conflict.

@gengjiawen gengjiawen mentioned this pull request May 9, 2019
Closed
4 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23011/

@ZYSzys
Copy link
Member

ZYSzys commented May 11, 2019 •
edited
Loading

Landed in 56ab82e 🎉

@ZYSzys ZYSzys closed this May 11, 2019
ZYSzys pushed a commit that referenced this pull request May 11, 2019
@gengjiawen @ZYSzys
src: extract common macro to util.h
56ab82e 
PR-URL: #27512
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request May 11, 2019
@gengjiawen @targos
src: extract common macro to util.h
a18692c 
PR-URL: #27512
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BridgeAR BridgeAR mentioned this pull request May 21, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis left review comments

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

+1 more reviewer

@refack refack refack approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@gengjiawen @BridgeAR @nodejs-github-bot @ZYSzys @refack @bnoordhuis @jasnell @Trott @addaleax @cjihrig