[v10.x] doc,n-api: update matrix for N-API version 4 #27832
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The N-API version was bumped to 4 for Node.js 10 in nodejs#25633 Refs: nodejs#25633
richardlau
added
doc
Merged
|
Once this lands in a Node.js 10.x release (i.e. the actual version of Node.js 10 that first supports N-API version 4 is known) a follow up PR needs to add that information to the N-API docs on |
|
@richardlau I assume the REPLACEME's are handled as part of the release process right? |
|
BethGriggs
approved these changes
May 24, 2019
codebytere
approved these changes
May 24, 2019
|
Landed on |
BethGriggs
pushed a commit
that referenced
this pull request
May 28, 2019
The N-API version was bumped to 4 for Node.js 10 in #25633 Refs: #25633 PR-URL: #27832 Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The N-API version was bumped to 4 for Node.js 10 in
#25633
Refs: #25633
This should land in the release with the above referenced PR.
cc @nodejs/lts @nodejs/n-api
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes