Skip to content

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 17, 2019

Refs: #21425 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. labels Jun 17, 2019
@nodejs-github-bot
Copy link
Collaborator

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 19, 2019
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

Refs: nodejs#21425 (comment)

PR-URL: nodejs#28270
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@Trott Trott force-pushed the moar-logging-statwatcher branch from b727277 to f28b1ed Compare June 20, 2019 04:12
@Trott
Copy link
Member Author

Trott commented Jun 20, 2019

Landed in f28b1ed

@Trott Trott merged commit f28b1ed into nodejs:master Jun 20, 2019
targos pushed a commit that referenced this pull request Jul 2, 2019
Refs: #21425 (comment)

PR-URL: #28270
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos mentioned this pull request Jul 2, 2019
@Trott Trott deleted the moar-logging-statwatcher branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
async_hooks Issues and PRs related to the async hooks subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants