Skip to content

test: fix order of assertion arguments in test-buffer-indexof #28359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

test: fix order of assertion arguments in test-buffer-indexof #28359

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
55e142e
test: change order of arguments
MistyBlunch Jun 21, 2019
194fda1
change the macos-firewall.sh
MistyBlunch Jun 21, 2019
e87cfa3
fix all
MistyBlunch Jun 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/parallel/test-buffer-indexof.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ assert.strictEqual(mixedByteStringUtf8.indexOf('bc'), 5);
assert.strictEqual(mixedByteStringUtf8.indexOf('bc', 5), 5);
assert.strictEqual(mixedByteStringUtf8.indexOf('bc', -8), 5);
assert.strictEqual(mixedByteStringUtf8.indexOf('\u03a3'), 7);
assert.strictEqual(-1, mixedByteStringUtf8.indexOf('\u0396'));
assert.strictEqual(mixedByteStringUtf8.indexOf('\u0396'), -1);


// Test complex string indexOf algorithms. Only trigger for long strings.
Expand Down
2 changes: 1 addition & 1 deletion tools/macos-firewall.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,4 +53,4 @@ then
$SFW --unblock "$OPENSSL_CLI_RELEASE"
else
echo "SocketFirewall not found in location: $SFW"
fi
fi