http: simplify drain #29081
Closed
http: simplify drain #29081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
lib / src
|
I think we should be using a symbol instead of an underscore-prefixed property. |
ronag
force-pushed
the
http-simplify-drain
branch
from
078268c to
054d050
Compare
|
@mscdex: fixed |
ronag
force-pushed
the
http-simplify-drain
branch
7 times, most recently
from
e82d80e to
a6486de
Compare
mscdex
reviewed
Aug 11, 2019
ronag
force-pushed
the
http-simplify-drain
branch
4 times, most recently
from
e9184d5 to
35ba9c3
Compare
mscdex
reviewed
Aug 11, 2019
ronag
force-pushed
the
http-simplify-drain
branch
3 times, most recently
from
2a6fb63 to
41a0458
Compare
|
@nodejs/http |
|
@ronag Can you give this a rebase to get rid of the conflicts? @nodejs/collaborators @nodejs/streams This could use some reviews. |
ronag
force-pushed
the
http-simplify-drain
branch
from
41a0458 to
dcca00f
Compare
|
@Trott fixed |
ronag
force-pushed
the
http-simplify-drain
branch
from
dcca00f to
73e760f
Compare
|
Landed in bdf07f4 |
Trott
pushed a commit
that referenced
this pull request
Aug 19, 2019
Simplify and slightly optimize draining outgoing http streams. Avoid extra event listener and inline with rest of the drain logic. PR-URL: #29081 Reviewed-By: Matteo Collina <[email protected]>
targos
pushed a commit
that referenced
this pull request
Aug 20, 2019
Simplify and slightly optimize draining outgoing http streams. Avoid extra event listener and inline with rest of the drain logic. PR-URL: #29081 Reviewed-By: Matteo Collina <[email protected]>
This was referenced Aug 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify and slightly optimize draining outgoing http streams.
Avoid extra event listener and inline with rest of the drain logic.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesNOTE TO SELF: After this is merged add
destroyedand ensure'drain'is not emitted afterdestroy(). Also look into removing unnecessary flush class in write.