Skip to content

Conversation

pd4d10
Copy link
Contributor

@pd4d10 pd4d10 commented Nov 19, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

If the symlink is invalid (target file or dir not exists), calling fs.existsSync() should return false.

There are some issues at Windows currently(#30538), so win32 platform is excluded temporarily. This condition could be removed after the issue fixed.

Seems this behavior is not mentioned explicitly in the documentation. If it is not as expected please correct me

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 19, 2019
@pd4d10
Copy link
Contributor Author

pd4d10 commented Nov 20, 2019

Changes merged to #30556. Closing

@pd4d10 pd4d10 closed this Nov 20, 2019
@pd4d10 pd4d10 deleted the patch-4 branch November 20, 2019 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants