Skip to content

Conversation

Sebastien-Ahkrin
Copy link
Contributor

Adding every TypedArray to the Primordials global objects.

And update v8 to ensure the usage of these TypedArray from primordials.

const {
  Array,
  ArrayBuffer,
  Float32Array,
  Float64Array,
  Int16Array,
  Int32Array,
  Int8Array,
  ObjectPrototypeToString,
  Uint16Array,
  Uint32Array,
  Uint8Array,
  Uint8ClampedArray,
} = primordials;

Thanks another time @targos
I hope this PR will help you :)

@Sebastien-Ahkrin
Copy link
Contributor Author

Hello,

I just have a test who fail this test

But i don't know why, someone have an idea ? 😢

thanks and sorry 😄

@tniessen tniessen added the lib / src Issues and PRs related to general changes in the lib or src directory. label Dec 4, 2019
@targos targos added the blocked PRs that are blocked by other issues or PRs. label Dec 4, 2019
@targos
Copy link
Member

targos commented Dec 4, 2019

This uncovered an existing bug.
Blocked by #30792

@targos
Copy link
Member

targos commented Dec 9, 2019

Refs: #30697

@targos targos removed the blocked PRs that are blocked by other issues or PRs. label Dec 15, 2019
@nodejs-github-bot
Copy link
Collaborator

@targos
Copy link
Member

targos commented Dec 16, 2019

Landed in 3743fe1...c88ace4

@targos targos closed this Dec 16, 2019
targos pushed a commit that referenced this pull request Dec 16, 2019
PR-URL: #30740
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Dec 16, 2019
PR-URL: #30740
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
PR-URL: #30740
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
PR-URL: #30740
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 17, 2019
targos pushed a commit that referenced this pull request Jan 14, 2020
PR-URL: #30740
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jan 14, 2020
PR-URL: #30740
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
PR-URL: #30740
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
PR-URL: #30740
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants