-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
test: check inspector command Debugger.setInstrumentationBreakpoint #31137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aduh95
merged 6 commits into
nodejs:main
from
ulitink:inspector-instrumentation-breakpoint
May 12, 2024
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5286379
test: add `Debugger.setInstrumentationBreakpoint` known issue
ulitink 6a74aa6
test: mute test-inspector-instrumentation-breakpoint
ulitink 38aa857
test: fix formatting in test-inspector-instrumentation-breakpoint
ulitink 833be9c
test: add description, fix linters
ulitink 9c8a452
lint
aduh95 29607a1
better skip
aduh95 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
console.log('dep loaded'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
require('./dep'); |
54 changes: 54 additions & 0 deletions
54
test/known_issues/test-inspector-instrumentation-breakpoint.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
// This test validates inspector's Debugger.setInstrumentationBreakpoint method. | ||
// Refs: https://github.com/nodejs/node/issues/31138 | ||
|
||
'use strict'; | ||
const common = require('../common'); | ||
|
||
common.skipIfInspectorDisabled(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It looks like skipping makes the test succeeds, which is considered a failure for |
||
|
||
const assert = require('assert'); | ||
const { resolve: UrlResolve } = require('url'); | ||
const fixtures = require('../common/fixtures'); | ||
const { NodeInstance } = require('../common/inspector-helper.js'); | ||
|
||
async function testBreakpointBeforeScriptExecution(session) { | ||
console.log('[test]', | ||
'Verifying debugger stops on start of each script ' + | ||
'(Debugger.setInstrumentationBreakpoint with beforeScriptExecution)'); | ||
const commands = [ | ||
{ 'method': 'Runtime.enable' }, | ||
{ 'method': 'Debugger.enable' }, | ||
{ 'method': 'Debugger.setInstrumentationBreakpoint', | ||
'params': { 'instrumentation': 'beforeScriptExecution' } }, | ||
{ 'method': 'Runtime.runIfWaitingForDebugger' }, | ||
]; | ||
|
||
await session.send(commands); | ||
|
||
// Break on start | ||
await session.waitForBreakOnLine( | ||
0, UrlResolve(session.scriptURL().toString(), 'main.js')); | ||
await session.send([{ 'method': 'Debugger.resume' }]); | ||
|
||
// Script loaded | ||
await session.waitForBreakOnLine( | ||
0, UrlResolve(session.scriptURL().toString(), 'main.js')); | ||
await session.send([{ 'method': 'Debugger.resume' }]); | ||
|
||
// Script loaded | ||
await session.waitForBreakOnLine( | ||
0, UrlResolve(session.scriptURL().toString(), 'dep.js')); | ||
await session.send([{ 'method': 'Debugger.resume' }]); | ||
} | ||
|
||
async function runTest() { | ||
const main = fixtures.path('inspector-instrumentation-breakpoint', 'main.js'); | ||
const child = new NodeInstance(['--inspect-brk=0'], '', main); | ||
|
||
const session = await child.connectInspectorSession(); | ||
await testBreakpointBeforeScriptExecution(session); | ||
await session.runToCompletion(); | ||
assert.strictEqual((await child.expectShutdown()).exitCode, 0); | ||
} | ||
|
||
runTest(); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.