[v10.x] deps: V8: backport b28637b4fe #31507
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
v10.x
v8 engine
addaleax
approved these changes
Jan 25, 2020
devnexen
approved these changes
Jan 25, 2020
|
The reporter of #31484 tried out this patch but he's unfortunately still seeing the crash. This PR fixes a crash though - the V8 regression test crashes without the fix and passes with. I'll update the commit log. |
Original commit message:
Apply duct-tape to load elimination
Load elimination is running together with to dead code elimination,
the latter of which might eliminate allocations (in particular
FinishRegion nodes). These are treated as alias nodes by load
elimination, and load elimination does not immediatelly learn that
a node has been disconnected. This causes load elimination to access
the inputs of dead code eliminated nodes while resolving renames,
which causes nullptr dereferences.
This CL modifies load elimination to not resolve to a nullptr alias
but simply stop before that.
Change-Id: If4cef061c7c0e25f353727c9e27f790439b0beb5
Bug: chromium:906406
Reviewed-on: https://chromium-review.googlesource.com/c/1346491
Commit-Queue: Sigurd Schneider <[email protected]>
Reviewed-by: Jaroslav Sevcik <[email protected]>
Cr-Commit-Position: refs/heads/master@{nodejs#57688}
|
Closing in favor of #31613. I reviewed load-elimination.cc and there were more places that had the same bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original commit message:
Fixes: #31484V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2819/