Skip to content

test: use portable EOL #32104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

test: use portable EOL #32104

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9cdc6b6
test: use portable EOL
HarshithaKP Mar 5, 2020
36943ab
fixup: address review comment
HarshithaKP Mar 6, 2020
8ba9a31
fixup: fix windows failure
HarshithaKP Mar 9, 2020
a6f14d9
fixup: fix linter error
HarshithaKP Mar 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions test/parallel/test-child-process-pipe-dataflow.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ const common = require('../common');
const assert = require('assert');
const path = require('path');
const fs = require('fs');
const os = require('os');
const spawn = require('child_process').spawn;
const tmpdir = require('../common/tmpdir');

Expand All @@ -25,8 +26,8 @@ const MB = KB * KB;
// meanings to new line - for example, line buffering.
// So cut the buffer into lines at some points, forcing
// data flow to be split in the stream.
for (let i = 0; i < KB; i++)
buf[i * KB] = 10;
for (let i = 1; i < KB; i++)
buf.write(os.EOL, i * KB);
fs.writeFileSync(file, buf.toString());

cat = spawn('cat', [file]);
Expand Down Expand Up @@ -61,6 +62,7 @@ const MB = KB * KB;
});

wc.stdout.on('data', common.mustCall((data) => {
assert.strictEqual(data.toString().trim(), MB.toString());
// Grep always adds one extra byte at the end.
assert.strictEqual(data.toString().trim(), (MB + 1).toString());
}));
}