Skip to content

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Oct 6, 2015

Update AUTHORS list using tools/update-authors.sh, this is a big one!

  • @reggi: you are going in to the AUTHORS file as reggi <[email protected]> based on your git info, could we have a full name for you instead of the nickname or would you prefer the shortened version?
  • @charlierudolph you are going in to the AUTHORS file as charlierudolph <[email protected]> based on your git info, could we have a full name for you instead of the nickname or would you prefer the shortened version? Charles Rudolph perhaps?
  • @johannhof you are going in to the AUTHORS file as `Johann <[email protected]

    ` based on your git info, could we have a full name for you instead or would you prefer the shortened version?

@johannhof
Copy link

I'd prefer my full name: Johann Hofmann 👍

@mscdex mscdex added the doc Issues and PRs related to the documentations. label Oct 6, 2015
@charlierudolph
Copy link

Charles Rudolph please. Thanks!

@reggi
Copy link
Contributor

reggi commented Oct 6, 2015

@rvagg Thanks! Full name please: Thomas Reggi

@rvagg
Copy link
Member Author

rvagg commented Oct 7, 2015

thanks @johannhof, @charlierudolph & @reggi! updated

PTAL reviewers, need signoff on this.

@evanlucas
Copy link
Contributor

LGTM

@rvagg rvagg closed this Oct 7, 2015
rvagg added a commit to rvagg/io.js that referenced this pull request Oct 7, 2015
Update AUTHORS list using tools/update-authors.sh

PR-URL: nodejs#3211
Reviewed-By: Evan Lucas <[email protected]>
@rvagg rvagg merged commit 0116da1 into nodejs:master Oct 7, 2015
@jasnell jasnell mentioned this pull request Oct 8, 2015
29 tasks
rvagg added a commit that referenced this pull request Oct 8, 2015
Update AUTHORS list using tools/update-authors.sh

PR-URL: #3211
Reviewed-By: Evan Lucas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants