src: munmap(2) upon class instance destructor #32570

gabrielschulhof · 2020-03-30T16:32:35Z

Replace OnScopeLeave with a class whose instance destructor performs
the munmap(2).

Signed-off-by: @gabrielschulhof
Fixes: #32532

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

src/large_pages/node_large_page.cc

gabrielschulhof · 2020-03-30T17:38:22Z

@addaleax @jasnell I have addressed your review comments.

nodejs-github-bot · 2020-03-30T17:39:12Z

CI: https://ci.nodejs.org/job/node-test-pull-request/30267/

* Clean up and co-locate explanation for what the code does to the top of the file. * Remove extraneous headers. * Remove the need for `OnScopeLeave` replacing it with a pair of labels `fail:` and `done:`. Re: nodejs#32570 Signed-off-by: Gabriel Schulhof <[email protected]>

gabrielschulhof · 2020-03-31T04:30:02Z

@jasnell @addaleax @devnexen having to declare the code for the class in the lpstub section I feel puts the complexity of using such a class beyond its usefulness. It's good to avoid placing too many things into that section, and especially classes. I have cleaned up the comments and includes in addition to what I did so far to make things cleaner, but I believe that #32576 is the simpler, cleaner solution. WDYT?

nodejs-github-bot · 2020-03-31T04:33:54Z

CI: https://ci.nodejs.org/job/node-test-pull-request/30276/

src/large_pages/node_large_page.cc

gabrielschulhof · 2020-03-31T14:43:54Z

@addaleax I have used FORCE_INLINE from debug_utils-inl.h.

nodejs-github-bot · 2020-03-31T14:45:47Z

CI: https://ci.nodejs.org/job/node-test-pull-request/30281/

nodejs-github-bot · 2020-03-31T15:39:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/30283/ ✔️

src/large_pages/node_large_page.cc

gabrielschulhof · 2020-04-02T00:21:10Z

@bnoordhuis I have made the changes you suggested.

src/large_pages/node_large_page.cc

nodejs-github-bot · 2020-04-02T03:31:39Z

CI: https://ci.nodejs.org/job/node-test-pull-request/30358/

nodejs-github-bot · 2020-04-03T14:24:25Z

CI: https://ci.nodejs.org/job/node-test-pull-request/30419/

nodejs-github-bot · 2020-04-03T16:31:52Z

CI: https://ci.nodejs.org/job/node-test-pull-request/30422/

nodejs-github-bot · 2020-04-03T16:58:57Z

CI: https://ci.nodejs.org/job/node-test-pull-request/30424/

Replace `OnScopeLeave` with a class whose instance destructor performs the munmap(2). Signed-off-by: Gabriel Schulhof <[email protected]> Fixes: nodejs#32532 Co-Authored-By: Anna Henningsen <[email protected]> Co-Authored-By: Ben Noordhuis <[email protected]>

gabrielschulhof · 2020-04-03T17:23:27Z

Rebased.

nodejs-github-bot · 2020-04-03T17:24:26Z

CI: https://ci.nodejs.org/job/node-test-pull-request/30425/

nodejs-github-bot · 2020-04-03T22:46:15Z

CI: https://ci.nodejs.org/job/node-test-pull-request/30434/

nodejs-github-bot · 2020-04-04T01:47:51Z

CI: https://ci.nodejs.org/job/node-test-pull-request/30435/

nodejs-github-bot · 2020-04-04T20:10:48Z

CI: https://ci.nodejs.org/job/node-test-pull-request/30446/

nodejs-github-bot · 2020-04-05T19:47:53Z

CI: https://ci.nodejs.org/job/node-test-pull-request/30465/

nodejs-github-bot · 2020-04-05T23:49:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/30487/

nodejs-github-bot · 2020-04-06T17:48:49Z

CI: https://ci.nodejs.org/job/node-test-pull-request/30504/

nodejs-github-bot · 2020-04-06T17:49:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/30505/

nodejs-github-bot · 2020-04-06T18:38:36Z

CI: https://ci.nodejs.org/job/node-test-pull-request/30513/ ✔️

Replace `OnScopeLeave` with a class whose instance destructor performs the munmap(2). Signed-off-by: Gabriel Schulhof <[email protected]> Fixes: #32532 PR-URL: #32570 Co-Authored-By: Anna Henningsen <[email protected]> Co-Authored-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]>

gabrielschulhof · 2020-04-06T19:55:27Z

Landed in a50745e.

Replace `OnScopeLeave` with a class whose instance destructor performs the munmap(2). Signed-off-by: Gabriel Schulhof <[email protected]> Fixes: #32532 PR-URL: #32570 Co-Authored-By: Anna Henningsen <[email protected]> Co-Authored-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]>

targos · 2020-04-22T17:42:08Z

Depends on the large pages change to land on v12.x

Replace `OnScopeLeave` with a class whose instance destructor performs the munmap(2). Signed-off-by: Gabriel Schulhof <[email protected]> Fixes: nodejs#32532 PR-URL: nodejs#32570 Co-Authored-By: Anna Henningsen <[email protected]> Co-Authored-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]>

Replace `OnScopeLeave` with a class whose instance destructor performs the munmap(2). Signed-off-by: Gabriel Schulhof <[email protected]> Fixes: #32532 PR-URL: #32570 Co-Authored-By: Anna Henningsen <[email protected]> Co-Authored-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]>

gabrielschulhof requested review from bnoordhuis, devnexen and jasnell March 30, 2020 16:32

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 30, 2020

addaleax approved these changes Mar 30, 2020

View reviewed changes

src/large_pages/node_large_page.cc Outdated Show resolved Hide resolved

src/large_pages/node_large_page.cc Outdated Show resolved Hide resolved

src/large_pages/node_large_page.cc Outdated Show resolved Hide resolved

jasnell reviewed Mar 30, 2020

View reviewed changes

src/large_pages/node_large_page.cc Outdated Show resolved Hide resolved

devnexen approved these changes Mar 30, 2020

View reviewed changes

gabrielschulhof force-pushed the large-pages-mmap-unique-pointer branch from a82c31c to 9e6aeb9 Compare March 31, 2020 04:22

gabrielschulhof mentioned this pull request Mar 31, 2020

src: further simplify large pages code #32576

Closed

2 tasks

addaleax approved these changes Mar 31, 2020

View reviewed changes

src/large_pages/node_large_page.cc Outdated Show resolved Hide resolved

src/large_pages/node_large_page.cc Outdated Show resolved Hide resolved

src/large_pages/node_large_page.cc Outdated Show resolved Hide resolved

jasnell approved these changes Mar 31, 2020

View reviewed changes

bnoordhuis reviewed Apr 1, 2020

View reviewed changes

src/large_pages/node_large_page.cc Outdated Show resolved Hide resolved

src/large_pages/node_large_page.cc Outdated Show resolved Hide resolved

src/large_pages/node_large_page.cc Outdated Show resolved Hide resolved

src/large_pages/node_large_page.cc Outdated Show resolved Hide resolved

gabrielschulhof force-pushed the large-pages-mmap-unique-pointer branch from 74779ed to c747290 Compare April 2, 2020 00:18

gabrielschulhof requested a review from bnoordhuis April 2, 2020 00:20

gabrielschulhof force-pushed the large-pages-mmap-unique-pointer branch 2 times, most recently from 0022b2e to a4a21f8 Compare April 2, 2020 00:23

gabrielschulhof commented Apr 2, 2020

View reviewed changes

src/large_pages/node_large_page.cc Outdated Show resolved Hide resolved

jasnell approved these changes Apr 2, 2020

View reviewed changes

gabrielschulhof force-pushed the large-pages-mmap-unique-pointer branch from a4a21f8 to 1f9ee3e Compare April 2, 2020 03:30

jasnell approved these changes Apr 3, 2020

View reviewed changes

gabrielschulhof force-pushed the large-pages-mmap-unique-pointer branch from 6686288 to 763da86 Compare April 3, 2020 17:22

gabrielschulhof closed this Apr 6, 2020

gabrielschulhof deleted the large-pages-mmap-unique-pointer branch April 6, 2020 19:55

targos mentioned this pull request Apr 13, 2020

v13.13.0 release proposal #32813

Merged

targos added the backport-blocked-v12.x label Apr 22, 2020

targos removed the backport-blocked-v12.x label Apr 25, 2020

targos mentioned this pull request May 2, 2020

v12.17.0 release proposal #33197

Merged

Uh oh!

src: munmap(2) upon class instance destructor #32570

src: munmap(2) upon class instance destructor #32570

Uh oh!

Conversation

gabrielschulhof commented Mar 30, 2020

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gabrielschulhof commented Mar 30, 2020

Uh oh!

nodejs-github-bot commented Mar 30, 2020

Uh oh!

gabrielschulhof commented Mar 31, 2020

Uh oh!

nodejs-github-bot commented Mar 31, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gabrielschulhof commented Mar 31, 2020

Uh oh!

nodejs-github-bot commented Mar 31, 2020

Uh oh!

nodejs-github-bot commented Mar 31, 2020 • edited by gabrielschulhof Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gabrielschulhof commented Apr 2, 2020

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 2, 2020

Uh oh!

nodejs-github-bot commented Apr 3, 2020

Uh oh!

nodejs-github-bot commented Apr 3, 2020

Uh oh!

nodejs-github-bot commented Apr 3, 2020

Uh oh!

gabrielschulhof commented Apr 3, 2020

Uh oh!

nodejs-github-bot commented Apr 3, 2020

Uh oh!

nodejs-github-bot commented Apr 3, 2020

Uh oh!

nodejs-github-bot commented Apr 4, 2020

Uh oh!

nodejs-github-bot commented Apr 4, 2020

Uh oh!

nodejs-github-bot commented Apr 5, 2020

Uh oh!

nodejs-github-bot commented Apr 5, 2020

Uh oh!

nodejs-github-bot commented Apr 6, 2020

Uh oh!

nodejs-github-bot commented Apr 6, 2020

Uh oh!

nodejs-github-bot commented Apr 6, 2020 • edited by gabrielschulhof Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gabrielschulhof commented Apr 6, 2020

Uh oh!

targos commented Apr 22, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

nodejs-github-bot commented Mar 31, 2020 •

edited by gabrielschulhof

Loading

nodejs-github-bot commented Apr 6, 2020 •

edited by gabrielschulhof

Loading