[v10.x] build: log detected compilers in --verbose mode #32820
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log the versions of the detected compilers when the configure script is run with `--verbose` to help verify which compiler is being used if multiple toolchains are installed on the system. Signed-off-by: Richard Lau <[email protected]> PR-URL: nodejs#32715 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
nodejs-github-bot
added
build
|
@richardlau PTAL, I dropped a few lines of your change that don't appear relevant to v10.x |
2 tasks
richardlau
approved these changes
Apr 13, 2020
gireeshpunathil
approved these changes
Apr 14, 2020
|
Landed in 9915774. |
richardlau
added a commit
that referenced
this pull request
Jul 1, 2020
Log the versions of the detected compilers when the configure script is run with `--verbose` to help verify which compiler is being used if multiple toolchains are installed on the system. Signed-off-by: Richard Lau <[email protected]> PR-URL: #32715 Backport-PR-URL: #32820 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport-of: #32715
Log the versions of the detected compilers when the configure script
is run with
--verboseto help verify which compiler is being used ifmultiple toolchains are installed on the system.
Signed-off-by: Richard Lau [email protected]
PR-URL: #32715
Reviewed-By: Gireesh Punathil [email protected]
Reviewed-By: Rod Vagg [email protected]
Reviewed-By: Sam Roberts [email protected]
Reviewed-By: Anna Henningsen [email protected]
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes