src: turn AllocatedBuffer into thin wrapper around v8::BackingStore #33381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
|
The CI failures should go away once #33321 lands. Until then, I’ve marked this as blocked. |
2 tasks
With V8 8.3, the two APIs basically have feature parity, so `AllocatedBuffer` can be turned into a wrapper around `v8::BackingStore`.
addaleax
force-pushed
the
allocated-buffer-backingstore
branch
from
58511a1 to
3ef0e38
Compare
jasnell
added a commit
to jasnell/node
that referenced
this pull request
May 14, 2020
Alternative to nodejs#33381 that reimplements that change on top of moving AllocatedBuffer out of env.h
|
I’ll close this as it’s included in #33291 now anyway. |
jasnell
added a commit
to jasnell/node
that referenced
this pull request
May 30, 2020
Alternative to nodejs#33381 that reimplements that change on top of moving AllocatedBuffer out of env.h
jasnell
added a commit
that referenced
this pull request
May 30, 2020
Alternative to #33381 that reimplements that change on top of moving AllocatedBuffer out of env.h PR-URL: #33291 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
Alternative to #33381 that reimplements that change on top of moving AllocatedBuffer out of env.h PR-URL: #33291 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]>
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
Alternative to #33381 that reimplements that change on top of moving AllocatedBuffer out of env.h PR-URL: #33291 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With V8 8.3, the two APIs basically have feature parity, so
AllocatedBuffercan be turned into a wrapper aroundv8::BackingStore.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes