Skip to content

Conversation

rexagod
Copy link
Member

@rexagod rexagod commented Jun 7, 2020

Disable lint checks (enable prohibited-strings remark-lint) for
doc-style-guide.md:66. This is producing lint errors in builds
on master.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Disable lint checks (enable prohibited-strings remark-lint) for
doc-style-guide.md:66. This was producing lint errors in builds
on master.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 7, 2020
@rexagod
Copy link
Member Author

rexagod commented Jun 7, 2020

ping @Trott

@rexagod rexagod changed the title doc: fix linting in doc-style-guide.md doc: fix linting in doc-style-guide.md [master-failing] Jun 7, 2020
@DerekNonGeneric
Copy link
Contributor

Fast track?

@rexagod
Copy link
Member Author

rexagod commented Jun 7, 2020

@DerekNonGeneric +1

Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
Copy link
Member

Trott commented Jun 8, 2020

+1 to fast-track. Anyone else?

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 8, 2020
@danbev
Copy link
Contributor

danbev commented Jun 8, 2020

Landed in b9739b6.

@danbev danbev closed this Jun 8, 2020
danbev pushed a commit that referenced this pull request Jun 8, 2020
Disable lint checks (enable prohibited-strings remark-lint) for
doc-style-guide.md:66. This was producing lint errors in builds
on master.

PR-URL: #33787
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
codebytere pushed a commit that referenced this pull request Jun 18, 2020
Disable lint checks (enable prohibited-strings remark-lint) for
doc-style-guide.md:66. This was producing lint errors in builds
on master.

PR-URL: #33787
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
@codebytere codebytere mentioned this pull request Jun 28, 2020
codebytere pushed a commit that referenced this pull request Jun 30, 2020
Disable lint checks (enable prohibited-strings remark-lint) for
doc-style-guide.md:66. This was producing lint errors in builds
on master.

PR-URL: #33787
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
codebytere pushed a commit that referenced this pull request Jul 9, 2020
Disable lint checks (enable prohibited-strings remark-lint) for
doc-style-guide.md:66. This was producing lint errors in builds
on master.

PR-URL: #33787
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
@codebytere codebytere mentioned this pull request Jul 13, 2020
codebytere pushed a commit that referenced this pull request Jul 14, 2020
Disable lint checks (enable prohibited-strings remark-lint) for
doc-style-guide.md:66. This was producing lint errors in builds
on master.

PR-URL: #33787
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants