Skip to content

src: fix minor comment typo in KeyObjectData #34167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

src: fix minor comment typo in KeyObjectData #34167

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Jul 2, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Jul 2, 2020
danbev added a commit that referenced this pull request Jul 6, 2020
@danbev
src: fix minor comment typo in KeyObjectData
67ba825 
PR-URL: #34167
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: David Carlier <[email protected]>
@danbev
Copy link
Contributor Author

danbev commented Jul 6, 2020

Landed in 67ba825.

@danbev danbev closed this Jul 6, 2020
@danbev danbev deleted the crypto_keyobjectdata_typo branch July 6, 2020 04:48
MylesBorins pushed a commit that referenced this pull request Jul 14, 2020
@danbev @MylesBorins
src: fix minor comment typo in KeyObjectData
6fae14a 
PR-URL: #34167
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: David Carlier <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jul 14, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Jul 16, 2020
@danbev @MylesBorins
src: fix minor comment typo in KeyObjectData
ed0f569 
PR-URL: #34167
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: David Carlier <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 27, 2020
@danbev @addaleax
src: fix minor comment typo in KeyObjectData
61339df 
PR-URL: #34167
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: David Carlier <[email protected]>
addaleax pushed a commit that referenced this pull request Sep 28, 2020
@danbev @addaleax
src: fix minor comment typo in KeyObjectData
090f869 
PR-URL: #34167
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: David Carlier <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@tniessen tniessen tniessen approved these changes

@richardlau richardlau richardlau approved these changes

+1 more reviewer

@devnexen devnexen devnexen approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@danbev @addaleax @tniessen @devnexen @richardlau @nodejs-github-bot