[v12.x backport] doc: deprecate process.umask() with no arguments #34591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a documentation deprecation for calling process.umask() with no arguments. PR-URL: nodejs#32499 Fixes: nodejs#32321 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Split doc entries for process.umask() into one entry for process.umask() (which is deprecated) and another for `process.umask(mask)` which is not deprecated. PR-URL: nodejs#32711 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
mscdex
reviewed
Aug 1, 2020
mscdex
reviewed
Aug 1, 2020
aduh95
commented
Aug 1, 2020
aduh95
commented
Aug 1, 2020
|
@cjihrig can you please review this? |
cjihrig
approved these changes
Aug 10, 2020
|
Based on #34592 (comment), this PR may be invalid. @targos what are your thoughts for this one? |
MylesBorins
pushed a commit
that referenced
this pull request
Aug 18, 2020
This commit introduces a documentation deprecation for calling process.umask() with no arguments. Backport-PR-URL: #34591 PR-URL: #32499 Fixes: #32321 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 18, 2020
Split doc entries for process.umask() into one entry for process.umask() (which is deprecated) and another for `process.umask(mask)` which is not deprecated. Backport-PR-URL: #34591 PR-URL: #32711 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
landed in 11a87ed...bb0cc00 |
BethGriggs
added
the
notable-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.js v12.x implements unflagged
worker_threads, thereforeprocess.umask()calls represent the same security risk as in Node.js v14.x.Note that this PR does not backport the runtime deprecation.
Refs: #32321
Refs: #32499
Refs: #32711
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes