Skip to content

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 1, 2020

validateTransportParams() only takes (and only uses) one argument.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott Trott requested a review from a team September 1, 2020 14:26
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/quic

@nodejs-github-bot nodejs-github-bot added dont-land-on-v12.x quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Sep 1, 2020
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 1, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 1, 2020
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 3, 2020

@Trott
Copy link
Member Author

Trott commented Sep 4, 2020

Landed in e5116b3

@Trott Trott deleted the quic-arg branch September 4, 2020 02:54
@Trott Trott merged commit e5116b3 into nodejs:master Sep 4, 2020
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
validateTransportParams() only takes (and only uses) one argument.

PR-URL: nodejs#35010
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quic Issues and PRs related to the QUIC implementation / HTTP/3.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants