Skip to content

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 14, 2020

URL that lacks a scheme gets treated as a relative URL. Add missing
https://.

Checklist

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Sep 14, 2020
@Trott Trott merged commit 3aab64c into nodejs:master Sep 16, 2020
@Trott
Copy link
Member Author

Trott commented Sep 16, 2020

Landed in 3aab64c

@Trott Trott deleted the ironic branch September 16, 2020 13:11
URL that lacks a scheme gets treated as a relative URL. Add missing
`https://`.

PR-URL: nodejs#35181
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 21, 2020
URL that lacks a scheme gets treated as a relative URL. Add missing
`https://`.

PR-URL: #35181
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Sep 21, 2020
4 tasks
addaleax pushed a commit that referenced this pull request Sep 22, 2020
URL that lacks a scheme gets treated as a relative URL. Add missing
`https://`.

PR-URL: #35181
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
URL that lacks a scheme gets treated as a relative URL. Add missing
`https://`.

PR-URL: nodejs#35181
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants