Skip to content

timers: correct explanation in comment #35437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

timers: correct explanation in comment #35437

wants to merge 1 commit into from

Conversation

wjabbour
Copy link
Contributor

@wjabbour wjabbour commented Oct 1, 2020

  • documentation is changed or added
  • commit message follows [commit guidelines]

@nodejs-github-bot nodejs-github-bot added the timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. label Oct 1, 2020
@Trott
Copy link
Member

Trott commented Oct 3, 2020

@nodejs/timers

@apapirovski
Copy link
Contributor

apapirovski commented Oct 3, 2020 •
edited
Loading

While this is accurate, I also don't think the current is inaccurate. Both descriptions are strictly speaking, incomplete. It's also kind of arguable whether the comment really says anything that the code doesn't already express...

@wjabbour
Copy link
Contributor Author

wjabbour commented Oct 3, 2020

Yeah I thought about removing the comment entirely

@nodejs nodejs deleted a comment Oct 3, 2020
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 5, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 5, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33402/

gireeshpunathil pushed a commit that referenced this pull request Oct 25, 2020
@wjabbour @gireeshpunathil
timers: correct explanation in comment
20a6ddc 
PR-URL: #35437
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@gireeshpunathil
Copy link
Member

landed in 20a6ddc

targos pushed a commit that referenced this pull request Nov 3, 2020
@wjabbour @targos
timers: correct explanation in comment
a41e3eb 
PR-URL: #35437
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Nov 3, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 8, 2020
@wjabbour @BethGriggs
timers: correct explanation in comment
e9c34ca 
PR-URL: #35437
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@wjabbour @BethGriggs
timers: correct explanation in comment
2af7c6b 
PR-URL: #35437
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@wjabbour @BethGriggs
timers: correct explanation in comment
41aac46 
PR-URL: #35437
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

+1 more reviewer

@apapirovski apapirovski apapirovski approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wjabbour @Trott @apapirovski @nodejs-github-bot @gireeshpunathil