Skip to content

lib: more global primordials #35499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

lib: more global primordials #35499

wants to merge 7 commits into from

Conversation

targos
Copy link
Member

@targos targos commented Oct 4, 2020

commit 1b7578c (HEAD -> more-primordials, origin/more-primordials)

lib: use remaining typed arrays from primordials

commit fef731c

lib: use Number.parseFloat from primordials

commit 99bed01

lib: use Number.parseInt from primordials

commit 5d6751b

lib: use global Error constructors from primordials

commit de9118b

errors: support possible deletion of globalThis.Error

Do not crash trying to access prepareStackTrace on `undefined`.

@targos targos requested review from a team as code owners October 4, 2020 14:11
@targos targos requested a review from a team October 4, 2020 14:11
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/modules
  • @nodejs/net
  • @nodejs/quic
  • @nodejs/startup
  • @nodejs/streams

@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Oct 4, 2020
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 4, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 4, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33380/

@targos targos mentioned this pull request Oct 4, 2020
Closed
3 tasks
ljharb
ljharb reviewed Oct 4, 2020
View reviewed changes
ryzokuken
ryzokuken reviewed Oct 6, 2020
View reviewed changes
Copy link
Contributor

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with @ljharb's suggestions applied.

ryzokuken
ryzokuken approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, missed the approve button.

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 6, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 6, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33429/

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2020

Landed in 1469984

@github-actions github-actions bot closed this Oct 7, 2020
nodejs-github-bot pushed a commit that referenced this pull request Oct 7, 2020
@targos @nodejs-github-bot
errors: support possible deletion of globalThis.Error
46526d6 
Do not crash trying to access prepareStackTrace on `undefined`.

PR-URL: #35499
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Oct 7, 2020
@targos @nodejs-github-bot
lib: use global Error constructors from primordials
4bc4f88 
PR-URL: #35499
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Oct 7, 2020
@targos @nodejs-github-bot
lib: use Number.parseInt from primordials
a073f53 
PR-URL: #35499
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Oct 7, 2020
@targos @nodejs-github-bot
lib: use Number.parseFloat from primordials
0708736 
PR-URL: #35499
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Oct 7, 2020
@targos @nodejs-github-bot
lib: use remaining typed arrays from primordials
1469984 
PR-URL: #35499
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
@targos targos deleted the more-primordials branch October 7, 2020 14:07
BethGriggs pushed a commit that referenced this pull request Oct 13, 2020
@targos @BethGriggs
errors: support possible deletion of globalThis.Error
3c90b1a 
Do not crash trying to access prepareStackTrace on `undefined`.

PR-URL: #35499
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
BethGriggs pushed a commit that referenced this pull request Oct 13, 2020
@targos @BethGriggs
lib: use global Error constructors from primordials
77f1e1e 
PR-URL: #35499
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
BethGriggs pushed a commit that referenced this pull request Oct 13, 2020
@targos @BethGriggs
lib: use Number.parseInt from primordials
5d727f0 
PR-URL: #35499
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
BethGriggs pushed a commit that referenced this pull request Oct 13, 2020
@targos @BethGriggs
lib: use Number.parseFloat from primordials
7e8fdd3 
PR-URL: #35499
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
BethGriggs pushed a commit that referenced this pull request Oct 13, 2020
@targos @BethGriggs
lib: use remaining typed arrays from primordials
fa171db 
PR-URL: #35499
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 14, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
@targos @MylesBorins
lib: use remaining typed arrays from primordials
f727998 
PR-URL: #35499
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
@targos @MylesBorins
lib: use remaining typed arrays from primordials
ad7281b 
PR-URL: #35499
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@targos @joesepi
errors: support possible deletion of globalThis.Error
5b74c64 
Do not crash trying to access prepareStackTrace on `undefined`.

PR-URL: nodejs#35499
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@targos @joesepi
lib: use global Error constructors from primordials
bf3ae8f 
PR-URL: nodejs#35499
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@targos @joesepi
lib: use Number.parseInt from primordials
0faadb5 
PR-URL: nodejs#35499
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@targos @joesepi
lib: use Number.parseFloat from primordials
9df61b3 
PR-URL: nodejs#35499
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@targos @joesepi
lib: use remaining typed arrays from primordials
eea53c8 
PR-URL: nodejs#35499
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Shingo Inoue <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb left review comments

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@benjamingr benjamingr benjamingr approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

+2 more reviewers

@Leko Leko Leko approved these changes

@ryzokuken ryzokuken ryzokuken approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@targos @nodejs-github-bot @ljharb @Trott @addaleax @benjamingr @Leko @joyeecheung @ryzokuken