Skip to content

Conversation

danielleadams
Copy link
Contributor

@danielleadams danielleadams commented Oct 7, 2020

Add Danielle Adams's release key.

Checklist

Add Danielle Adams's release key.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 7, 2020
@richardlau richardlau added the notable-change PRs with changes that should be highlighted in changelogs. label Oct 7, 2020
Copy link
Member

@BethGriggs BethGriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can import the key too

Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2020
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 20, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 20, 2020
@github-actions
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/35545
✔  Done loading data for nodejs/node/pull/35545
----------------------------------- PR info ------------------------------------
Title      doc: add release key for Danielle Adams (#35545)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     danielleadams:add-danielleadams-gpg-key -> nodejs:master
Labels     doc, notable-change
Commits    1
 - doc: add release key for Danielle Adams
Committers 1
 - Danielle Adams 
PR-URL: https://github.com/nodejs/node/pull/35545
Reviewed-By: Richard Lau 
Reviewed-By: Beth Griggs 
Reviewed-By: Shelley Vohr 
Reviewed-By: Myles Borins 
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/35545
Reviewed-By: Richard Lau 
Reviewed-By: Beth Griggs 
Reviewed-By: Shelley Vohr 
Reviewed-By: Myles Borins 
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ✖  Last GitHub CI failed
   ℹ  Doc-only changes
   ℹ  This PR was created on Wed, 07 Oct 2020 18:05:22 GMT
   ✔  Approvals: 6
   ✔  - Richard Lau (@richardlau): https://github.com/nodejs/node/pull/35545#pullrequestreview-504142713
   ✔  - Beth Griggs (@BethGriggs) (TSC): https://github.com/nodejs/node/pull/35545#pullrequestreview-504166059
   ✔  - Shelley Vohr (@codebytere) (TSC): https://github.com/nodejs/node/pull/35545#pullrequestreview-504259102
   ✔  - Myles Borins (@MylesBorins) (TSC): https://github.com/nodejs/node/pull/35545#pullrequestreview-504384484
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/35545#pullrequestreview-504708969
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/35545#pullrequestreview-512089607
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

Commit Queue action: https://github.com/nodejs/node/actions/runs/317344068

@github-actions github-actions bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 20, 2020
@MylesBorins
Copy link
Contributor

Landed in 6b6bbfe

MylesBorins pushed a commit that referenced this pull request Oct 20, 2020
Add Danielle Adams's release key.

PR-URL: #35545
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
BethGriggs pushed a commit that referenced this pull request Oct 21, 2020
Add Danielle Adams's release key.

PR-URL: #35545
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Oct 21, 2020
BethGriggs added a commit that referenced this pull request Oct 21, 2020
Notable changes:

- **crypto**: fix regression on randomFillSync (James M Snell)
  (#35723)
  * This fixes issue #35722.
- **doc**: add release key for Danielle Adams (Danielle Adams)
  (#35545)

PR-URL: #35736
BethGriggs added a commit that referenced this pull request Oct 21, 2020
Notable changes:

- **crypto**: fix regression on randomFillSync (James M Snell)
  (#35723)
  - This fixes issue #35722.
- **deps**: upgrade npm to 7.0.3 (Ruy Adorno)
  (#35724)
- **doc**: add release key for Danielle Adams (Danielle Adams)
  (#35545)

PR-URL: #35736
BethGriggs added a commit that referenced this pull request Oct 21, 2020
Notable changes:

- **crypto**: fix regression on randomFillSync (James M Snell)
  (#35723)
  - This fixes issue #35722.
- **deps**: upgrade npm to 7.0.3 (Ruy Adorno)
  (#35724)
- **doc**: add release key for Danielle Adams (Danielle Adams)
  (#35545)

PR-URL: #35736
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants