Skip to content

os: refactor to use more primordials #36284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

os: refactor to use more primordials #36284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions lib/os.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,13 @@
'use strict';

const {
ArrayPrototypePush,
Float64Array,
NumberParseInt,
ObjectDefineProperties,
StringPrototypeEndsWith,
StringPrototypeSlice,
StringPrototypeSplit,
SymbolToPrimitive,
} = primordials;

Expand Down Expand Up @@ -104,7 +108,7 @@ function cpus() {
const result = [];
let i = 0;
while (i < data.length) {
result.push({
ArrayPrototypePush(result, {
model: data[i++],
speed: data[i++],
times: {
Expand Down Expand Up @@ -135,15 +139,16 @@ function tmpdir() {
path = process.env.TEMP ||
process.env.TMP ||
(process.env.SystemRoot || process.env.windir) + '\\temp';
if (path.length > 1 && path.endsWith('\\') && !path.endsWith(':\\'))
path = path.slice(0, -1);
if (path.length > 1 && StringPrototypeEndsWith(path, '\\') &&
!StringPrototypeEndsWith(path, ':\\'))
path = StringPrototypeSlice(path, 0, -1);
} else {
path = safeGetenv('TMPDIR') ||
safeGetenv('TMP') ||
safeGetenv('TEMP') ||
'/tmp';
if (path.length > 1 && path.endsWith('/'))
path = path.slice(0, -1);
if (path.length > 1 && StringPrototypeEndsWith(path, '/'))
path = StringPrototypeSlice(path, 0, -1);
}

return path;
Expand Down Expand Up @@ -177,7 +182,7 @@ function getCIDR(address, netmask, family) {
groupLength = 16;
}

const parts = netmask.split(split);
const parts = StringPrototypeSplit(netmask, split);
for (var i = 0; i < parts.length; i++) {
if (parts[i] !== '') {
const binary = NumberParseInt(parts[i], range);
Expand Down Expand Up @@ -221,7 +226,7 @@ function networkInterfaces() {

const existing = result[name];
if (existing !== undefined)
existing.push(entry);
ArrayPrototypePush(existing, entry);
else
result[name] = [entry];
}
Expand Down